Increased Robustness: Prevent crashes if dataset contains only identical elements #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case, (for example a degenerated probability distribution of 0 for all datapoints) the "abm" variant crashes during predict, because the logistic regression is called with the wrong amount of parameters
python/betacal/beta_calibration.py
Lines 115 to 120 in 3a9dbb4
This happens because the logistic regressions coefficients get 0 for such a degenerated case, and the lines above are executed accidentally.
De-aliasing the accidental 0 case with a None variable solves that issue.